Open
Conversation
razvan
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
adwk67
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
adwk67
reviewed
Feb 27, 2026
Member
adwk67
left a comment
adwk67
left a comment
There was a problem hiding this comment.
Not finished yet, but here are some initial comments.
| ---- | ||
| <1> The kind of the resource is `SparkApplicationTemplate` to indicate that this is an application template. | ||
| <2> Name of the application template. | ||
| <3> The value of `mainApplicationFile` is set to a placeholder value, which will be overridden by the application resource. Similarly to the application, The fields `sparkImage`, `mode`, `mainClass`, and `mainApplicationFile` are required for the template to be valid. |
Member
There was a problem hiding this comment.
Why do we have to have define sparkImage etc. both in the template and the app? Is the plan with v1alpha2 to remove them as being mandatory in the application so we can only have them in the template (or override them)? If so, can they be optional in the template?
|
|
||
| Spark application templates are used to define reusable configurations for Spark applications. | ||
| When you have many applications with similar configurations, templates can help you avoid duplication by grouping common settings together. | ||
| Application templates are available for the `v1alpha1` version of the SparkApplication custom resource and share the exact same structure as the SparkApplication resource, but with some differences in the way the operator handles them: |
Member
There was a problem hiding this comment.
Do we know yet if the plan is to keep versions in step with another (e.g a v1alpha2 is created for one entity when the other entity is bumped to v1alpha2). I think that might make mapping between app and template a little easier.
| When you have many applications with similar configurations, templates can help you avoid duplication by grouping common settings together. | ||
| Application templates are available for the `v1alpha1` version of the SparkApplication custom resource and share the exact same structure as the SparkApplication resource, but with some differences in the way the operator handles them: | ||
|
|
||
| 1. Application templates are cluster wide resources, while Spark application resources are namespace-scoped. This means that application templates can be used across multiple namespaces, while Spark application resources are limited to the namespace they are created in. |
Member
There was a problem hiding this comment.
Sentences should be on new lines in the docs e.g.
Suggested change
| 1. Application templates are cluster wide resources, while Spark application resources are namespace-scoped. This means that application templates can be used across multiple namespaces, while Spark application resources are limited to the namespace they are created in. | |
| 1. Application templates are cluster wide resources, while Spark application resources are namespace-scoped. | |
| This means that application templates can be used across multiple namespaces, while Spark application resources are limited to the namespace they are created in. |
(not sure if we want indenting there...)
| mainApplicationFile: "/examples.jar" | ||
| ---- | ||
| <1> Enable application template merging for this application. | ||
| <2> The name of the application templates to reference. The settings from these templates will be merged together in the order they are referenced, with `app-template-0` having the lowest precedence and `app-template-2` having the highest precedence. Tha application fields have the highest overall precedence and will override any conflicting settings from the templates. |
Member
There was a problem hiding this comment.
Suggested change
| <2> The name of the application templates to reference. The settings from these templates will be merged together in the order they are referenced, with `app-template-0` having the lowest precedence and `app-template-2` having the highest precedence. Tha application fields have the highest overall precedence and will override any conflicting settings from the templates. | |
| <2> The name of the application templates to reference. The settings from these templates will be merged together in the order they are referenced, with `app-template-0` having the lowest precedence and `app-template-2` having the highest precedence. The application fields have the highest overall precedence and will override any conflicting settings from the templates. |
| metadata: | ||
| name: app | ||
| annotations: | ||
| spark-application.template.merge: "true" # <1> |
Member
There was a problem hiding this comment.
I think it would be good to include all available annotations in the example to be comprehensive.
…late run up to stackabletech/operator-templating@dc62e95 (#662) Reference-to: stackabletech/operator-templating@dc62e95 (UBI10 rollout, new rust toolchain)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: stackabletech/issues#817
🟢 CI: https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/63/